wanwu/deer-flow
1
0
Fork 0
mirror of https://gitee.com/wanwujie/deer-flow synced 2026-04-08 16:24:45 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix: added configuration of python_repl (#503)

Browse Source 
* fix: added configuration of python_repl

* fix the lint and unit test errors

* fix the lint and unit test errors

* fix:the lint check errors
This commit is contained in:
Willem Jiang
2025-08-06 14:27:03 +08:00
committed by GitHub
parent 4218cddab5
commit 9e691ecf20
11 changed files with 194 additions and 77 deletions
Download Patch File Download Diff File Expand all files Collapse all files

90
tests/unit/tools/test_python_repl.py
View File

@@ -1,6 +1,7 @@
# Copyright (c) 2025 Bytedance Ltd. and/or its affiliates
# SPDX-License-Identifier: MIT
import os
import pytest
from unittest.mock import patch
from src.tools.python_repl import python_repl_tool
@@ -8,6 +9,7 @@ from src.tools.python_repl import python_repl_tool
class TestPythonReplTool:
@patch.dict(os.environ, {"ENABLE_PYTHON_REPL": "true"})
@patch("src.tools.python_repl.repl")
@patch("src.tools.python_repl.logger")
def test_successful_code_execution(self, mock_logger, mock_repl):
@@ -26,24 +28,20 @@ class TestPythonReplTool:
assert code in result
assert expected_output in result
@patch.dict(os.environ, {"ENABLE_PYTHON_REPL": "true"})
@patch("src.tools.python_repl.repl")
@patch("src.tools.python_repl.logger")
def test_invalid_input_type(self, mock_logger, mock_repl):
# Arrange
invalid_code = 123
# Act & Assert - expect ValidationError from LangChain
with pytest.raises(Exception) as exc_info:
# Act & Assert - expect ValidationError when passing invalid input
with pytest.raises(Exception): # Could be ValidationError or similar
python_repl_tool(invalid_code)
# Verify that it's a validation error
assert "ValidationError" in str(
type(exc_info.value)
) or "validation error" in str(exc_info.value)
# The REPL should not be called since validation fails first
mock_repl.run.assert_not_called()
@patch.dict(os.environ, {"ENABLE_PYTHON_REPL": "true"})
@patch("src.tools.python_repl.repl")
@patch("src.tools.python_repl.logger")
def test_code_execution_with_error_in_result(self, mock_logger, mock_repl):
@@ -62,6 +60,7 @@ class TestPythonReplTool:
assert code in result
assert error_result in result
@patch.dict(os.environ, {"ENABLE_PYTHON_REPL": "true"})
@patch("src.tools.python_repl.repl")
@patch("src.tools.python_repl.logger")
def test_code_execution_with_exception_in_result(self, mock_logger, mock_repl):
@@ -80,6 +79,7 @@ class TestPythonReplTool:
assert code in result
assert exception_result in result
@patch.dict(os.environ, {"ENABLE_PYTHON_REPL": "true"})
@patch("src.tools.python_repl.repl")
@patch("src.tools.python_repl.logger")
def test_code_execution_raises_exception(self, mock_logger, mock_repl):
@@ -98,6 +98,7 @@ class TestPythonReplTool:
assert code in result
assert repr(exception) in result
@patch.dict(os.environ, {"ENABLE_PYTHON_REPL": "true"})
@patch("src.tools.python_repl.repl")
@patch("src.tools.python_repl.logger")
def test_successful_execution_with_calculation(self, mock_logger, mock_repl):
@@ -117,6 +118,7 @@ class TestPythonReplTool:
assert code in result
assert expected_output in result
@patch.dict(os.environ, {"ENABLE_PYTHON_REPL": "true"})
@patch("src.tools.python_repl.repl")
@patch("src.tools.python_repl.logger")
def test_empty_string_code(self, mock_logger, mock_repl):
@@ -132,6 +134,7 @@ class TestPythonReplTool:
mock_logger.info.assert_called_with("Code execution successful")
assert "Successfully executed:" in result
@patch.dict(os.environ, {"ENABLE_PYTHON_REPL": "true"})
@patch("src.tools.python_repl.repl")
@patch("src.tools.python_repl.logger")
def test_logging_calls(self, mock_logger, mock_repl):
@@ -145,3 +148,74 @@ class TestPythonReplTool:
# Assert
mock_logger.info.assert_any_call("Executing Python code")
mock_logger.info.assert_any_call("Code execution successful")
# New tests for configuration behavior
@patch.dict(os.environ, {"ENABLE_PYTHON_REPL": "false"})
@patch("src.tools.python_repl.logger")
def test_tool_disabled(self, mock_logger):
# Arrange
code = "print('test')"
# Act
result = python_repl_tool(code)
# Assert
mock_logger.warning.assert_called_with(
"Python REPL tool is disabled. Please enable it in environment configuration."
)
assert "Tool disabled:" in result
assert "Python REPL tool is disabled" in result
@patch.dict(os.environ, {}, clear=True)
@patch("src.tools.python_repl.logger")
def test_tool_disabled_by_default(self, mock_logger):
# Arrange - remove any existing ENABLE_PYTHON_REPL variable
if "ENABLE_PYTHON_REPL" in os.environ:
del os.environ["ENABLE_PYTHON_REPL"]
code = "print('test')"
# Act
result = python_repl_tool(code)
# Assert
mock_logger.warning.assert_called_with(
"Python REPL tool is disabled. Please enable it in environment configuration."
)
assert "Tool disabled:" in result
@pytest.mark.parametrize("env_value", ["true", "True", "TRUE", "1", "yes", "on"])
@patch("src.tools.python_repl.repl")
@patch("src.tools.python_repl.logger")
def test_tool_enabled_with_various_truthy_values(
self, mock_logger, mock_repl, env_value
):
# Arrange
with patch.dict(os.environ, {"ENABLE_PYTHON_REPL": env_value}):
code = "print('enabled')"
expected_output = "enabled\n"
mock_repl.run.return_value = expected_output
# Act
result = python_repl_tool(code)
# Assert
mock_repl.run.assert_called_once_with(code)
assert "Successfully executed:" in result
@pytest.mark.parametrize(
"env_value", ["false", "False", "FALSE", "0", "no", "off", ""]
)
@patch("src.tools.python_repl.logger")
def test_tool_disabled_with_various_falsy_values(self, mock_logger, env_value):
# Arrange
with patch.dict(os.environ, {"ENABLE_PYTHON_REPL": env_value}):
code = "print('disabled')"
# Act
result = python_repl_tool(code)
# Assert
mock_logger.warning.assert_called_with(
"Python REPL tool is disabled. Please enable it in environment configuration."
)
assert "Tool disabled:" in result