mirror of
https://gitee.com/wanwujie/deer-flow
synced 2026-04-09 08:44:45 +08:00
Replace all bare print() calls with proper logging using Python's standard logging module across the deerflow harness package. Changes across 8 files (16 print statements replaced): - agents/middlewares/clarification_middleware.py: use logger.info/debug - agents/middlewares/memory_middleware.py: use logger.debug - agents/middlewares/thread_data_middleware.py: use logger.debug - agents/middlewares/view_image_middleware.py: use logger.debug - agents/memory/queue.py: use logger.info/debug/warning/error - agents/lead_agent/prompt.py: use logger.error - skills/loader.py: use logger.warning - skills/parser.py: use logger.error Each file follows the established codebase convention: import logging logger = logging.getLogger(__name__) Log levels chosen based on message semantics: - debug: routine operational details (directory creation, timer resets) - info: significant state changes (memory queued, updates processed) - warning: recoverable issues (config load failures, skipped updates) - error: unexpected failures (parsing errors, memory update errors) Note: client.py is intentionally excluded as it uses print() for CLI output, which is the correct behavior for a command-line client. Co-authored-by: moose-lab <moose-lab@users.noreply.github.com>
199 lines
5.9 KiB
Python
199 lines
5.9 KiB
Python
"""Memory update queue with debounce mechanism."""
|
|
|
|
import logging
|
|
import threading
|
|
import time
|
|
from dataclasses import dataclass, field
|
|
from datetime import datetime
|
|
from typing import Any
|
|
|
|
from deerflow.config.memory_config import get_memory_config
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
|
@dataclass
|
|
class ConversationContext:
|
|
"""Context for a conversation to be processed for memory update."""
|
|
|
|
thread_id: str
|
|
messages: list[Any]
|
|
timestamp: datetime = field(default_factory=datetime.utcnow)
|
|
agent_name: str | None = None
|
|
|
|
|
|
class MemoryUpdateQueue:
|
|
"""Queue for memory updates with debounce mechanism.
|
|
|
|
This queue collects conversation contexts and processes them after
|
|
a configurable debounce period. Multiple conversations received within
|
|
the debounce window are batched together.
|
|
"""
|
|
|
|
def __init__(self):
|
|
"""Initialize the memory update queue."""
|
|
self._queue: list[ConversationContext] = []
|
|
self._lock = threading.Lock()
|
|
self._timer: threading.Timer | None = None
|
|
self._processing = False
|
|
|
|
def add(self, thread_id: str, messages: list[Any], agent_name: str | None = None) -> None:
|
|
"""Add a conversation to the update queue.
|
|
|
|
Args:
|
|
thread_id: The thread ID.
|
|
messages: The conversation messages.
|
|
agent_name: If provided, memory is stored per-agent. If None, uses global memory.
|
|
"""
|
|
config = get_memory_config()
|
|
if not config.enabled:
|
|
return
|
|
|
|
context = ConversationContext(
|
|
thread_id=thread_id,
|
|
messages=messages,
|
|
agent_name=agent_name,
|
|
)
|
|
|
|
with self._lock:
|
|
# Check if this thread already has a pending update
|
|
# If so, replace it with the newer one
|
|
self._queue = [c for c in self._queue if c.thread_id != thread_id]
|
|
self._queue.append(context)
|
|
|
|
# Reset or start the debounce timer
|
|
self._reset_timer()
|
|
|
|
logger.info("Memory update queued for thread %s, queue size: %d", thread_id, len(self._queue))
|
|
|
|
def _reset_timer(self) -> None:
|
|
"""Reset the debounce timer."""
|
|
config = get_memory_config()
|
|
|
|
# Cancel existing timer if any
|
|
if self._timer is not None:
|
|
self._timer.cancel()
|
|
|
|
# Start new timer
|
|
self._timer = threading.Timer(
|
|
config.debounce_seconds,
|
|
self._process_queue,
|
|
)
|
|
self._timer.daemon = True
|
|
self._timer.start()
|
|
|
|
logger.debug("Memory update timer set for %ss", config.debounce_seconds)
|
|
|
|
def _process_queue(self) -> None:
|
|
"""Process all queued conversation contexts."""
|
|
# Import here to avoid circular dependency
|
|
from deerflow.agents.memory.updater import MemoryUpdater
|
|
|
|
with self._lock:
|
|
if self._processing:
|
|
# Already processing, reschedule
|
|
self._reset_timer()
|
|
return
|
|
|
|
if not self._queue:
|
|
return
|
|
|
|
self._processing = True
|
|
contexts_to_process = self._queue.copy()
|
|
self._queue.clear()
|
|
self._timer = None
|
|
|
|
logger.info("Processing %d queued memory updates", len(contexts_to_process))
|
|
|
|
try:
|
|
updater = MemoryUpdater()
|
|
|
|
for context in contexts_to_process:
|
|
try:
|
|
logger.info("Updating memory for thread %s", context.thread_id)
|
|
success = updater.update_memory(
|
|
messages=context.messages,
|
|
thread_id=context.thread_id,
|
|
agent_name=context.agent_name,
|
|
)
|
|
if success:
|
|
logger.info("Memory updated successfully for thread %s", context.thread_id)
|
|
else:
|
|
logger.warning("Memory update skipped/failed for thread %s", context.thread_id)
|
|
except Exception as e:
|
|
logger.error("Error updating memory for thread %s: %s", context.thread_id, e)
|
|
|
|
# Small delay between updates to avoid rate limiting
|
|
if len(contexts_to_process) > 1:
|
|
time.sleep(0.5)
|
|
|
|
finally:
|
|
with self._lock:
|
|
self._processing = False
|
|
|
|
def flush(self) -> None:
|
|
"""Force immediate processing of the queue.
|
|
|
|
This is useful for testing or graceful shutdown.
|
|
"""
|
|
with self._lock:
|
|
if self._timer is not None:
|
|
self._timer.cancel()
|
|
self._timer = None
|
|
|
|
self._process_queue()
|
|
|
|
def clear(self) -> None:
|
|
"""Clear the queue without processing.
|
|
|
|
This is useful for testing.
|
|
"""
|
|
with self._lock:
|
|
if self._timer is not None:
|
|
self._timer.cancel()
|
|
self._timer = None
|
|
self._queue.clear()
|
|
self._processing = False
|
|
|
|
@property
|
|
def pending_count(self) -> int:
|
|
"""Get the number of pending updates."""
|
|
with self._lock:
|
|
return len(self._queue)
|
|
|
|
@property
|
|
def is_processing(self) -> bool:
|
|
"""Check if the queue is currently being processed."""
|
|
with self._lock:
|
|
return self._processing
|
|
|
|
|
|
# Global singleton instance
|
|
_memory_queue: MemoryUpdateQueue | None = None
|
|
_queue_lock = threading.Lock()
|
|
|
|
|
|
def get_memory_queue() -> MemoryUpdateQueue:
|
|
"""Get the global memory update queue singleton.
|
|
|
|
Returns:
|
|
The memory update queue instance.
|
|
"""
|
|
global _memory_queue
|
|
with _queue_lock:
|
|
if _memory_queue is None:
|
|
_memory_queue = MemoryUpdateQueue()
|
|
return _memory_queue
|
|
|
|
|
|
def reset_memory_queue() -> None:
|
|
"""Reset the global memory queue.
|
|
|
|
This is useful for testing.
|
|
"""
|
|
global _memory_queue
|
|
with _queue_lock:
|
|
if _memory_queue is not None:
|
|
_memory_queue.clear()
|
|
_memory_queue = None
|